-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't try to recreate pull secrets for refreshing gcp-auth #11945
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.3s 47.9s 49.3s 47.6s 46.7s Times for minikube ingress: 32.8s 32.3s 31.8s 31.4s 31.9s docker driver with docker runtime
Times for minikube ingress: 36.5s 36.5s 34.5s 35.0s 36.5s Times for minikube start: 23.2s 23.0s 23.3s 21.9s 21.7s docker driver with containerd runtime
Times for minikube start: 31.5s 44.1s 43.5s 43.8s 43.8s |
@sharifelgamal is there a way for CC devs to try out this patch? |
Before it's merged, you can download a binary at https://storage.googleapis.com/minikube-builds/11945/minikube-linux-amd64 (or darwin or whatever you'd like, they're all there) |
kvm2 driver with docker runtime
Times for minikube (PR 11945) start: 48.0s 47.3s 46.8s 47.3s 47.9s Times for minikube ingress: 31.8s 32.8s 33.9s 31.8s 31.8s docker driver with docker runtime
Times for minikube start: 22.2s 21.7s 21.0s 22.3s 22.4s Times for minikube ingress: 35.0s 31.5s 35.5s 35.5s 35.5s docker driver with containerd runtime
Times for minikube start: 27.4s 42.9s 43.5s 43.3s 43.5s |
kvm2 driver with docker runtime
Times for minikube (PR 11945) start: 48.0s 47.0s 53.1s 47.5s 47.4s Times for minikube ingress: 41.3s 31.8s 40.3s 39.7s 32.8s docker driver with docker runtime
Times for minikube start: 22.7s 21.2s 21.8s 22.2s 21.6s Times for minikube ingress: 31.5s 36.5s 31.5s 35.5s 36.5s docker driver with containerd runtime
Times for minikube start: 26.8s 43.2s 43.7s 43.5s 43.1s |
/retest-this-please |
@briandealwis curious have u had a chance to try this out ? |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube (PR 11945) start: 48.8s 49.7s 48.8s 48.4s 48.2s Times for minikube ingress: 31.3s 31.4s 31.3s 31.8s 31.3s docker driver with docker runtime
Times for minikube (PR 11945) start: 22.3s 22.4s 22.8s 22.5s 22.3s Times for minikube ingress: 35.0s 35.1s 30.5s 35.0s 36.0s docker driver with containerd runtime
Times for minikube start: 26.6s 44.7s 43.0s 48.4s 43.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an attempt to fix #11565